Page 1 of 1

nucleo-G474re misconfiguration WS, variant_NUCLEO_G474RE.cpp

Posted: Thu Nov 09, 2023 2:42 am
by MasterT
Just noticed, that init config in the variant_NUCLEO_G474RE.cpp has this line:
if (HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_8) != HAL_OK) {

same time RM0440 page 98 ( Rev 7 ) says: 4 WS (5 CPU cycles)≤ 170 MHz.

I changed my code to:
if (HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_4) != HAL_OK) {

and get some improvement in DSP performance, new version runs 14.8 msec vs 17.3 msec original.

Re: nucleo-G474re misconfiguration WS, variant_NUCLEO_G474RE.cpp

Posted: Thu Nov 09, 2023 10:29 am
by fpiSTM
Could you open an issue? And why not provide a PR too ;)

Re: nucleo-G474re misconfiguration WS, variant_NUCLEO_G474RE.cpp

Posted: Thu Nov 09, 2023 1:01 pm
by MasterT
Is it not right place to open a "ticket"? Excuse my ignorance, what is PR?

Re: nucleo-G474re misconfiguration WS, variant_NUCLEO_G474RE.cpp

Posted: Thu Nov 09, 2023 2:13 pm
by fpiSTM
No worry. That's fine you open it here as a first discussion.
As it seems relevant, you can open a issue here:
https://github.com/stm32duino/Arduino_Core_STM32/issues

PR is for Pull request: https://docs.github.com/en/pull-request ... l-requests

Re: nucleo-G474re misconfiguration WS, variant_NUCLEO_G474RE.cpp

Posted: Thu Nov 16, 2023 9:47 am
by fpiSTM
@MasterT

I've made a PR anyway having an issue would be fine to link it to the PR. ;)
https://github.com/stm32duino/Arduino_C ... /pull/2186