First pass at a BluePill Variant

The official STMicroelectronics Arduino core
User avatar
RogerClark
Posts: 5620
Joined: Mon Apr 27, 2015 10:36 am
Location: Melbourne, Australia
Contact:

Re: First pass at a BluePill Variant

Postby RogerClark » Sun Nov 13, 2016 7:23 pm

I will merge Daniel's repo into the stm32 repo today.

As I already did a local merge of the previous stable commit and it worked fine for me

danieleff
Posts: 220
Joined: Thu Sep 01, 2016 8:52 pm
Location: Hungary
Contact:

Re: First pass at a BluePill Variant

Postby danieleff » Mon Nov 14, 2016 7:58 am

Ollie wrote:Daniel,

I had not visited your Github previously and now I have to say that I like your programming style a lot. The information you have at

https://github.com/danieleff/Arduino_Core_STM32F1

is very useful for all STM32 developers. There are so huge amount of details that I do wonder, what kind of quality assurance methods you have used to gain confidence that the information is correct.

Cheers, Ollie

Thanks.
I think the best QA in programming is peer review. Because I do not know if my code is correct or not. And the best way for peer review is small commits with no noise, and that these changes can be easily reviewed and tried out.

User avatar
RogerClark
Posts: 5620
Joined: Mon Apr 27, 2015 10:36 am
Location: Melbourne, Australia
Contact:

Re: First pass at a BluePill Variant

Postby RogerClark » Mon Nov 14, 2016 8:18 am

See

viewtopic.php?f=16&t=1553&start=20

Its mostly working.

The only issue at the moment is that the ValueLine Discovery F100 library won't compile because of the USB files


Return to “STM Core”

Who is online

Users browsing this forum: No registered users and 1 guest