Fixed utoa() function definition

Post Reply
User avatar
RogerClark
Posts: 7691
Joined: Mon Apr 27, 2015 10:36 am
Location: Melbourne, Australia
Contact:

Fixed utoa() function definition

Post by RogerClark » Mon Jul 03, 2017 6:46 am

https://github.com/rogerclarkmelbourne/ ... 2/pull/271

Need to confirm if there is any impact from this. (probably its OK)

stevestrong
Posts: 2070
Joined: Mon Oct 19, 2015 12:06 am
Location: Munich, Germany
Contact:

Re: Fixed utoa() function definition

Post by stevestrong » Mon Jul 03, 2017 12:22 pm

Worked fine for me.

victor_pv
Posts: 1869
Joined: Mon Apr 27, 2015 12:12 pm

Re: Fixed utoa() function definition

Post by victor_pv » Mon Jul 03, 2017 2:27 pm

I haven't tested, but a search in the core to see if any other file used it only shows 2 matches. They both take an input as char and int and pass it to utoa, so changing the function from long to int should not affect them.
https://github.com/rogerclarkmelbourne/ ... String.cpp

https://github.com/rogerclarkmelbourne/ ... String.cpp

User avatar
RogerClark
Posts: 7691
Joined: Mon Apr 27, 2015 10:36 am
Location: Melbourne, Australia
Contact:

Re: Fixed utoa() function definition

Post by RogerClark » Mon Jul 03, 2017 10:36 pm

Thanks

I'll merge this PR

Edit.

Looks like the merge needs to be done manually :-(

Post Reply