Fix if serial

victor_pv
Posts: 1745
Joined: Mon Apr 27, 2015 12:12 pm

Re: Fix if serial

Post by victor_pv » Wed Jul 05, 2017 4:03 pm

RogerClark wrote:
Wed Jul 05, 2017 4:45 am
Actually,
It looks like I need to manually merge if Serial because it removes isConnected, which some people may already be using in their sketches

I think I need to keep isConnected by perhaps mark it as deprecated
Roger this PR keeps isConnected:
https://github.com/rogerclarkmelbourne/ ... 0159d8cR83

It also marks it as deprecated with a nice message advising what to use in its place, so I think you can merge the PR like it is.

User avatar
RogerClark
Posts: 7465
Joined: Mon Apr 27, 2015 10:36 am
Location: Melbourne, Australia
Contact:

Re: Fix if serial

Post by RogerClark » Wed Jul 05, 2017 10:37 pm

Thanks

I didnt noticed the isConnected had been effectively moved to the header, I thought it has just been deleted from the .c

Its merged now.

Thanks

Post Reply