Fix bug in serial communication during SPI debug

Post Reply
User avatar
RogerClark
Posts: 7680
Joined: Mon Apr 27, 2015 10:36 am
Location: Melbourne, Australia
Contact:

Fix bug in serial communication during SPI debug

Post by RogerClark » Mon Jul 03, 2017 6:56 am

https://github.com/rogerclarkmelbourne/ ... 2/pull/246

Seems to make changes beyond its title

Also, I am not sure why there are print statements in the SPI class at all for debugging. IMHO, there is no need to have these, and they could be removed.

There is also an unassociated change for Nucleo serial port, and its not good practice to do unrelated changes within the same PR

stevestrong
Posts: 2049
Joined: Mon Oct 19, 2015 12:06 am
Location: Munich, Germany
Contact:

Re: Fix bug in serial communication during SPI debug

Post by stevestrong » Mon Jul 03, 2017 9:44 am

Yes, the PRs should be separated.

I also opt for removing the DEBUG lines from SPI.

victor_pv
Posts: 1860
Joined: Mon Apr 27, 2015 12:12 pm

Re: Fix bug in serial communication during SPI debug

Post by victor_pv » Mon Jul 03, 2017 10:59 pm

I agree on separating it in 2 PRs, and agree on removing the debug print statements.
I think SPI is mature enough to not need much debugging unless we are adding something new to it.

I can't comment on whether the changes for the Nucleo are needed since it seems to number the Serial ports in a different order than the hardware numbering. Is that to match pin labels in the nucleo board?

Post Reply